Conversation
Member
doyoonkim3312
commented
Jul 23, 2025
- DI Structure Improvement
- Commonly used system services and CoroutineDispatchers are now being injected via DI
- Scene-based components have been applied.
- Inject necessary system services via Dependency Injection.
DI enhancement
- Files would be placed under corresponding directory (Components, Modules, Util)
- Apply Scene-based Component.
- Update hard-coded temporary value for Tip Category (SYS_NOTICE -> UPDATES)
# Conflicts: # app/src/main/java/com/doyoonkim/knutice/MainApplication.kt # app/src/main/java/com/doyoonkim/knutice/di/components/AppComponent.kt # app/src/main/java/com/doyoonkim/knutice/di/modules/AppModule.kt
- Improve DI structure
* Apply Scene-based Component for constructing independent dependency graph of each scene on feature.
- Improve DI structure
* Isolate DI Component for FirebaseMessagingService.
- Construct independent dependency graph.
- Uses different retrofit service with shorter timeout.
- Remove Unnecessary Timeout handling.
(Retrofit Service would have its own OkHTTP client with shorter timeout (5 seconds)
- Inject necessary system service.
* AlarmManager instance is now being injected to NotificationAlarmScheduler.
- Decentralize DI modules under :feature and :data modules.
- Create new Singleton object 'DeviceToken' to manage FCM token during the application lifecycle.
- Remove unnecessary component/module from the DI structure.
- Inject Singleton-based DeviceToken instance to RemoteSource.
- Create separate module to provide KnuticeApiService with shorter timeout applied. (For PushNotificationHandler)
- Move navigation-related logics to :app module from :feature module. - Apply Scene-based components to corresponding destination.
- Remove unnecessary module dependencies from MainActivityComponent.
- Remove unnecessary field variable from the MainActivity - Apply Separated MainActivityComponent for DI.
- Apply Separated top-level AppComponent.
- Dynamically apply string resources for Submission Error
- Add necessary localized string resources.
- Remove unnecessary function parameter (viewModelFactory)
- Clean up unused import statments.
- Update Version Code (24 -> 25)
- Update Version Code (25 -> 26)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.