Skip to content

[PR] KNUTICE 1.5.0 RC 2#43

Merged
doyoonkim3312 merged 25 commits intoreleasefrom
development
Jul 23, 2025
Merged

[PR] KNUTICE 1.5.0 RC 2#43
doyoonkim3312 merged 25 commits intoreleasefrom
development

Conversation

@doyoonkim3312
Copy link
Member

  • DI Structure Improvement
    • Commonly used system services and CoroutineDispatchers are now being injected via DI
    • Scene-based components have been applied.

  - Inject necessary system services via Dependency Injection.
 DI enhancement
  - Files would be placed under corresponding directory (Components, Modules, Util)
  - Apply Scene-based Component.
  - Update hard-coded temporary value for Tip Category (SYS_NOTICE -> UPDATES)
# Conflicts:
#	app/src/main/java/com/doyoonkim/knutice/MainApplication.kt
#	app/src/main/java/com/doyoonkim/knutice/di/components/AppComponent.kt
#	app/src/main/java/com/doyoonkim/knutice/di/modules/AppModule.kt
  - Improve DI structure
    * Apply Scene-based Component for constructing independent dependency graph of each scene on feature.
  - Improve DI structure
    * Isolate DI Component for FirebaseMessagingService.
     - Construct independent dependency graph.
     - Uses different retrofit service with shorter timeout.
  - Remove Unnecessary Timeout handling.
    (Retrofit Service would have its own OkHTTP client with shorter timeout (5 seconds)
  - Inject necessary system service.
    * AlarmManager instance is now being injected to NotificationAlarmScheduler.
  - Decentralize DI modules under :feature and :data modules.
  - Create new Singleton object 'DeviceToken' to manage FCM token during the application lifecycle.
  - Remove unnecessary component/module from the DI structure.
  - Inject Singleton-based DeviceToken instance to RemoteSource.
  - Create separate module to provide KnuticeApiService with shorter timeout applied. (For PushNotificationHandler)
  - Move navigation-related logics to :app module from :feature module.
  - Apply Scene-based components to corresponding destination.
  - Remove unnecessary module dependencies from MainActivityComponent.
  - Remove unnecessary field variable from the MainActivity
  - Apply Separated MainActivityComponent for DI.
  - Apply Separated top-level AppComponent.
  - Dynamically apply string resources for Submission Error
  - Add necessary localized string resources.
  - Remove unnecessary function parameter (viewModelFactory)
  - Clean up unused import statments.
  - Update Version Code (24 -> 25)
  - Update Version Code (25 -> 26)
@doyoonkim3312 doyoonkim3312 merged commit 3b18c96 into release Jul 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant